-
-
Notifications
You must be signed in to change notification settings - Fork 420
Android release docs #5957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android release docs #5957
Conversation
def androidReleaseKeyName: Option[String] = Some("releaseKey.jks") | ||
def androidReleaseKeyAlias: T[Option[String]] = Task { Some("releaseKey") } | ||
def androidReleaseKeyPass: T[Option[String]] = Task { Some("MillBuildTool") } | ||
def androidReleaseKeyStorePass: T[Option[String]] = Task { Some("MillBuildTool") } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's provide here a good default guide, perhaps with env vars
> keytool -genkey -v -keystore releaseKey.jks \ | ||
-storepass <PASS> -keyalg RSA \ | ||
-keysize 2048 -validity 10000 \ | ||
-alias releaseKey -keypass <PASS> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"$KEYTOOL_PASS"
maybe, and use the same name above like, Task.env
Looking at the current docs we have, I'm wondering how we can make this more user friendly. Perhaps having something like app.release.androidApk , with release being an inner trait, or app.androidReleaseApk but I think with mill's design the former could work better. Of course this is not in the scope of this PR |
Lgtm |
While it's good to document the status quo, we should aim for a dedicated |
I agree, I've played a bit with some flows, I haven't decided yet the best approach, I tried mixing a trait first but that has some complications. The best "interface" I came up with so far is a release module (like the androidTest) where you will be able to do I'll get that into a proper PR soon EDIT: what is a cross-axis? |
One parameter (of potentially many parameters) of a cross module. E.g. Making an Android module a cross-module with a |
Thanks, I think I get it and it may actually be a better fit than what I was going for, I will give it a go |
From a usability aspect, I think I prefer the sub-module approach. the most trivial reason is, that you don't need to provide any parameters. Many web-frameworks like Vaadin also have a notion of |
The thing is, there maybe more build types than debug and release, which is why I keep delaying this until we are happy feature wise and tested various apps, so we won't have the extra complexity of build variants. I'll need to experiment more with this, I think now we are in a good place with features and we can start looking at different variants (e.g. some apps have a performance profiling variant). I'll tag you to the related PRs so we can discuss more on concrete examples/implementations, I don't expect to get this right from the first try, but let's see how it goes |
Uh oh!
There was an error while loading. Please reload this page.